Add secret support for credentials

openfaas-incubator / vcenter-connector

Extend vCenter with OpenFaaS

MIT License

28 stars 8 forks source link

Add secret support for credentials #24

Closed alexellis closed 4 years ago

alexellis commented 5 years ago

When flags are not given for username/password, the code will now read this from Kubernetes secrets on disk.

Fixes #25

Testing

Building the Go code.

@mikejwhitehead PTAL?

You'll need to:

build an image or use mine
create your Kubernetes secret (1 secret, two literals / files)
edit your Kubernetes YAML to bind the two secrets (see how we do it for basic auth)

Signed-off-by: Alex Ellis alexellis2@gmail.com

alexellis commented 5 years ago

openfaas/vcenter-connector:0.2.2-rc1

alexellis commented 5 years ago

Docker image: openfaas/vcenter-connector:0.2.2-rc2 - see updated YAML files for how the secrets are bound @mikejwhitehead

alexellis commented 5 years ago

@embano1 PTAL?

embano1 commented 5 years ago

Should we add a test for the secrets handling?

embano1 commented 5 years ago

Feel free to either make these proposed changes directly or merge this PR and I'll do a follow up PR with some minor changes and adding a unit test for the new secrets handling.

alexellis commented 4 years ago

Would you like to test this version with the updated feedback?

embano1 commented 4 years ago

Thx Alex, tested the new functionality and works like a charm!

alexellis commented 4 years ago

Brilliant!

Perhaps the BU using the connector may like to contribute in some way via https://insiders.openfaas.io/ ?