Include Test case for Limits

nitishkumar71 commented 2 years ago

Signed-off-by: Nitishkumar Singh nitishkumarsingh71@gmail.com

Certifier should support validation of memory limit in faasd and openfaas

Description

Motivation and Context

[x] I have raised an issue to propose this change this is required

Closes #81

How Has This Been Tested?

New test case has been included to test memory limit
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

[x] I've read the CONTRIBUTION guide
[x] My commit message has a body and describes how this was tested and why it is required.
[x] I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

[x] My code follows the code style of this project.
[x] I have added tests to cover my changes.

Docs:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

nitishkumar71 commented 2 years ago

Can we run the workflow again? The issue is same as #82 where mostly failure happens for logs.

alexellis commented 2 years ago

You can run this locally with go test -run "^NameOfTest$" and then see the individual test fail for faasd to show that the memory limit wasn't detected. Then we'll cut a new release of faasd we can re-run the tests and see it pass.

alexellis commented 2 years ago

2021-12-05T17:50:48.3391383Z --- FAIL: Test_Deploy_MetaData/test_listing_functions (0.02s) 2021-12-05T17:50:48.3392022Z deploy_test.go:162: got nil, expected Limits &{5M 100m}

Perfect!

alexellis commented 2 years ago

We now have a new release which populates the memory value in the API, so let's run these tests again once the binaries are ready.

After that, if the faasd tests pass, I'll merge this PR.

https://github.com/openfaas/faasd/releases/tag/0.14.4

nitishkumar71 commented 2 years ago

We now have a new release which populates the memory value in the API, so let's run these tests again once the binaries are ready.

After that, if the faasd tests pass, I'll merge this PR.

https://github.com/openfaas/faasd/releases/tag/0.14.4

Can we run it now? I don't have permission for same.

nitishkumar71 commented 2 years ago

@alexellis @LucasRoesler I have removed faasd memory test for now and have kept it just for faas-netes. Will work on it once we have resolved openfaas/faasd#228

LucasRoesler commented 2 years ago

I am going to merge this because the test that is failing is the scaling test, which has been flaky and we are still investigating. The new limits test is fine

openfaas / certifier