openfaas / connector-sdk

SDK for connecting events to functions
MIT License
54 stars 25 forks source link

Add timeout for http.Client #10

Closed embano1 closed 5 years ago

embano1 commented 5 years ago

Signed-off-by: Michael Gasch embano1@live.com

alexellis commented 5 years ago

Thank you for this PR 👍 🎉

Could we also add the context in the c.Do? The reason I ask is that the http.Client timeout does not give the correct HTTP status code, it will just disconnect. That's the reason I added what looks like duplication in openfaas/faas/gateway and openfaas-incubator/of-watchdog.