Closed embano1 closed 5 years ago
Thank you for this PR 👍 🎉
Could we also add the context in the c.Do? The reason I ask is that the http.Client timeout does not give the correct HTTP status code, it will just disconnect. That's the reason I added what looks like duplication in openfaas/faas/gateway and openfaas-incubator/of-watchdog.
http.Client
context.Context
for thehttpReq
in invoker'sc.Do()
is not needed right now as the underlying http.Client now has a timeout for the request (unless there's need for context.Context)Signed-off-by: Michael Gasch embano1@live.com