search

openfaas / connector-sdk

SDK for connecting events to functions
MIT License
54 stars 25 forks source link

Enable multiple topics per function #21

Closed rgee0 closed 5 years ago

rgee0 commented 5 years ago

A function’s topic annotation value is a CSV. The service map should be 1..1 topic to 1..* functions. The connecter SDK currently makes the serviceMap key from the entire annotation value, which means where a CSV has been used in the function annotation value then the serviceMap key will be the full CSV.

This change introduces breaking of the topic annotation CSV using comma as a delimiter so that a function can be mapped to multiple topics.

Fixes #20

Signed-off-by: Richard Gee richard@technologee.co.uk

alexellis commented 5 years ago

Why is this a breaking change?

rgee0 commented 5 years ago

Why is this a breaking change?

I didn't think it was?

alexellis commented 5 years ago

RE: this comment

This change introduces breaking of the topic annotation CSV using comma as a delimiter so that a function can be mapped to multiple topics.