search

openfaas / connector-sdk

SDK for connecting events to functions
MIT License
54 stars 25 forks source link

Fix bad merge and bad commit to 'master'. #38

Closed bmcustodio closed 4 years ago

bmcustodio commented 4 years ago

Follow-up to #33. It also seems that https://github.com/openfaas-incubator/connector-sdk/commit/ac35b633765e95e6a2e9e53123ec101f185bf4da removed the debug argument from NewInvoker while keeping PrintSync in a call to NewInvoker. I think that CI should be set up for this project to avoid this kind of issues in the future.

derek[bot] commented 4 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 4 years ago

Thanks for catching this, my tests didn't pick this up which involved compiling the tester app. I've since added a Makefile to catch this and will enable a Travis CI.