openfaas / connector-sdk

SDK for connecting events to functions
MIT License
54 stars 25 forks source link

Fix issue where provider doesn't support namespaces #39

Closed alexellis closed 4 years ago

alexellis commented 4 years ago

Expected behaviour

If a provider doesn't support namespaces, then the previous behaviour or a default behaviour should be used

Current behaviour

As outlined by @bmcstdio, the code will throw a fatal error instead.

https://github.com/openfaas-incubator/connector-sdk/blob/master/types/controller.go#L156-L159

Possible solution

Context

faas-netes is unaffected, but users wanting to bring in the latest release of the connector-sdk will encounter issues when used with the operator or faas-swarm.

alexellis commented 4 years ago

cc: @bmcstdio @viveksyngh @LucasRoesler