openfaas / connector-sdk

SDK for connecting events to functions
MIT License
54 stars 25 forks source link

Provide guidance on Rebuild and Upstream timers #45

Closed embano1 closed 2 years ago

embano1 commented 4 years ago

My actions before raising this issue

For controller authors it would be nice to provide some guidance on sensible defaults for RebuildInterval and UpstreamTimeout. Currently, if none if these are provided it's unclear what the defaults are (in the case of UpstreamTimeout there is no timeout at all which could cause blocking issues during network/API problems).

Expected Behaviour

Provide guidance (docs) on sensible defaults or check provided values (empty) in the code and enforce timeouts respectively.

Current Behaviour

If neither of these intervals/timeouts are specified the behavior of the connector using the SDK is undetermined, especially in cases of network/API interruptions.

Possible Solution

alexellis commented 4 years ago

Sounds good to me, can you suggest where to do this? The README / tester app are the two places I can think of.

embano1 commented 4 years ago

Yep, those two please :)