openfaas / connector-sdk

SDK for connecting events to functions
MIT License
54 stars 25 forks source link

Tester build broken due to creds type mismatch #47

Open pmundt opened 4 years ago

pmundt commented 4 years ago

My actions before raising this issue

Trying to run the default tester fails due to a type mismatch on the auth creds.

Expected Behaviour

It does whatever it's supposed to do when it runs successfully

Current Behaviour

$ go run cmd/tester/main.go 
# command-line-arguments
cmd/tester/main.go:37:35: cannot use creds (type *"connector-sdk/vendor/github.com/openfaas/faas-provider/auth".BasicAuthCredentials) as type *"github.com/openfaas-incubator/connector-sdk/vendor/github.com/openfaas/faas-provider/auth".BasicAuthCredentials in argument to "github.com/openfaas-incubator/connector-sdk/types".NewController

Possible Solution

I haven't had a chance to look into this in detail, but as the other connectors don't have this issue, assume it's just a dependency issue in the connector-sdk tree.

Steps to Reproduce (for bugs)

  1. git clone https://github.com/openfaas-incubator/connector-sdk.git
  2. cd connector-sdk
  3. go run cmd/tester/main.go

Context

I ran into this while developing a new connector but ultimately was able to get going with the MQTT and Kafka connectors as a reference instead. While it hasn't had a great impact, I don't believe there is anything extraordinary about my development environment, so others are likely to hit this as well.

Your Environment