Update faas-provider and tester - Githubissues

openfaas / connector-sdk

SDK for connecting events to functions

MIT License

54 stars 25 forks source link

Update faas-provider and tester #54

Closed LucasRoesler closed 3 years ago

LucasRoesler commented 3 years ago

Description

Update the faas-provider and make the required renames
Replace remaining incubator references in the tester binary. The package was moved to the main organization, openfaas, and should import from the new location

Motivation and Context

[ ] I have raised an issue to propose this change (required)
[ ] My issue has received approval from the maintainers or lead with the design/approved label

Relates to c5027ccb35a33178e52ef016a7c368afbf7cf859

How Has This Been Tested?

the tester can no build

cd  cmd/tester && go build

Then run the tests from the root

$ go test ./... -count=1
?       github.com/openfaas/connector-sdk/cmd/tester    [no test files]
ok      github.com/openfaas/connector-sdk/types 0.005s

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

alexellis commented 3 years ago

I made a mistake in v0.16.0 of the faas-provider, which was unintended. Can you vendor in v0.16.1 and revert the change for Name->Service in the function status please?