openfaas / connector-sdk

SDK for connecting events to functions
MIT License
54 stars 25 forks source link

Error Response when no matching functions #62

Open prsh9 opened 3 years ago

prsh9 commented 3 years ago

Description

Send response to indicate no matching functions are found for the topic.

Motivation and Context

Currently when invoking a function on a topic with controller.Invoke() and there are no matching functions (probably due to function still being loaded, topic-map not refreshed) there is no way to acknowledge upstream. Consider using amqp which uses manual auto-ack, there is no way to determine the failure and do a negative ack / track such invocation failure.

Fixes issue #61

How Has This Been Tested?

Performed manual testing and recorded the behaviour.

Types of changes

Checklist:

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.