Add `BasicAuth` field to `ControllerConfig` type - Githubissues

openfaas / connector-sdk

SDK for connecting events to functions

MIT License

54 stars 25 forks source link

Add `BasicAuth` field to `ControllerConfig` type #63

Closed viveksyngh closed 3 years ago

viveksyngh commented 3 years ago

Signed-off-by: Vivek Singh vivekkmr45@yahoo.in

Adding a BasicAuth field to the ControllerConfig type which can be used to configure controllers basic auth configurations.

Description

Motivation and Context

[ ] I have raised an issue to propose this change (required)
[ ] My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I've read the CONTRIBUTION guide
[ ] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

alexellis commented 3 years ago

Thanks for the PR @viveksyngh, here's the release you can use to make use of this: https://github.com/openfaas/connector-sdk/releases/tag/v0.6.2