Update cron package to v3

viveksyngh commented 3 years ago

This commit updates cron package version to v3 and uses github.com/robfig/cron/v3 instead of gopkg.in/robfig/cron.v2

Fixes #12

Description

Motivation and Context

[x] I have raised an issue to propose this change (required)
[ ] My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Tested on my local cluster with kind

 kubectl logs -n openfaas deploy/cron-connector -f
2021/01/30 14:46:53 Version: 66adc8a2f30d643c09accbab8ba032e4f1804c23   Commit: dev
2021/01/30 14:47:43 added function nodeinfo
2021/01/30 14:50:00 Executed function: nodeinfo
2021/01/30 14:50:00 connector-sdk got result: [200] cron-function => nodeinfo (104) bytes

 faas-cli store deploy nodeinfo --annotation schedule="*/0 * * * *" --annotation topic=cron-function
kubectl logs -n openfaas deploy/cron-connector -f
2021/01/30 14:46:53 Version: 66adc8a2f30d643c09accbab8ba032e4f1804c23   Commit: dev
2021/01/30 14:47:43 added function nodeinfo
2021/01/30 14:50:00 Executed function: nodeinfo
2021/01/30 14:50:00 connector-sdk got result: [200] cron-function => nodeinfo (104) bytes
2021/01/30 14:53:22 deleted function nodeinfo

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 3 years ago

😢

How Has This Been Tested? (empty)

😲

Description (empty)

alexellis commented 3 years ago

Hey @viveksyngh, can you do a little testing on your PR over the weekend? It doesn't have to be extensive, just something to show it still works.

viveksyngh commented 3 years ago

@alexellis Updated with test results

alexellis commented 3 years ago

Thank you for that 👍

openfaas / cron-connector