fix: issue with basic auth disabled

viveksyngh commented 3 years ago

Fix issue with the cron connector when it is deployed with basic auth disabled.

Fixes: #22

Description

Motivation and Context

[x] I have raised an issue to propose this change ([required(https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))
[ ] My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

This has been tested on local kind cluster with local build deployed.

Openfaas was deployed with basic auth disabled and then cron connector was deployed with basic auth disabled.

arkade install openfaas --basic-auth=false
arkade install cron-connector --set basicAuth=false

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 2 years ago

@nitishkumar71 would you like to see if this is still an issue, and send a similar / updated PR if we need it?

Thanks,

Alex

openfaas / cron-connector