openfaas / cron-connector

Invoke functions on a schedule.
MIT License
39 stars 10 forks source link

Cron-Connector only looks for functions in openfaas-fn namespace #6

Closed jdewinne closed 3 years ago

jdewinne commented 3 years ago

The cron-connector should get all the functions for all the namespaces, by first invoking getNamespaces and for each namespace getting all the functions. https://github.com/openfaas/cron-connector/blob/master/main.go#L66

Related to alpha feature namespaces

alexellis commented 3 years ago

Thanks for your interest

Are you willing to work on this feature?

If it's for a commercial user of openfaas, check out this thread -> https://github.com/openfaas/faas/issues/1591

Alex

jdewinne commented 3 years ago

Sure.

This might be a bigger change than expected. I already looked at the dependencies, and it looks like several of the sdk dependencies are outdated. So might take some more work than just adding a loop going through all the namespaces. Should the upgrade of the dependencies be a separate issue?

Thanks, Joris

On Fri, Nov 13, 2020 at 2:05 PM Alex Ellis notifications@github.com wrote:

Thanks for your interest

Are you willing to work on this feature?

If it's for a commercial user of openfaas, check out this thread -> openfaas/faas#1591 https://github.com/openfaas/faas/issues/1591

Alex

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openfaas/cron-connector/issues/6#issuecomment-727058996, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMBRNCUYRFZNU5LKFH6M3DSPWUSBANCNFSM4TVC3U4A .

jdewinne commented 3 years ago

See above PR. Open for feedback!

alexellis commented 3 years ago

Thanks for contributing.

I've asked @viveksyngh to take a look and help you.

noam09 commented 3 years ago

Hey @jdewinne, is this still in progress?

jdewinne commented 3 years ago

Should be working. @alexellis can this be merged?

alexellis commented 3 years ago

@jdewinne this is an issue, please comment on the linked PR

alexellis commented 3 years ago

PR #7 raised for this