openfaas / docs

Official Docs for OpenFaaS
https://docs.openfaas.com/
MIT License
67 stars 101 forks source link

Suspect missing port in line 73 of /docs/languages/dockerfile.md #378

Closed hyperion-journey closed 4 months ago

hyperion-journey commented 4 months ago

Suspect missing port :8080 in URL

In section "Build and deploy the function" (Line 73)

https://github.com/openfaas/docs/blame/ebc543451edc8c96ef678850df6239c44dd6fcd3/docs/languages/dockerfile.md#L73

(https://docs.openfaas.com/languages/dockerfile/#turn-a-cli-into-a-function):

Currently reads:

curl -s http://127.0.0.1 -d "https://www.openfaas.com"

Please consider changing curl command to include the port 8080 as indicated below:

curl -s http://127.0.0.1:8080 -d "https://www.openfaas.com"

Expected Behaviour

curl -s http://127.0.0.1:8080 -d "https://www.openfaas.com"

returns:

2024/07/09 17:28:26 Forking fprocess.
2024/07/09 17:28:26 Wrote 24 Bytes - Duration: 0.000927s

with CURLE_OK (0) error code returned

Current Behaviour

curl -s http://127.0.0.1 -d "https://www.openfaas.com"

returns:

with CURLE_COULDNT_CONNECT (7) error code returned

Your Environment

/docs/languages/dockerfile.md line 73

alexellis commented 4 months ago

Hi, we will get that updated. Thanks for the issue.

alexellis commented 4 months ago

Fixed in: c6c91d7