search

openfaas / faas-cli

Official CLI for OpenFaaS
https://www.openfaas.com/
Other
794 stars 226 forks source link

Push latest image to Docker Hub #772

Closed LucasRoesler closed 4 years ago

LucasRoesler commented 4 years ago

Expected Behaviour

docker pull openfaas/faas-cli:latest should work

Current Behaviour

The image is not availabe

Possible Solution

On each release, we should push both the versioned tag and a new latest tag.

Context

This could be helpful in CI situations, like Jenkins, Travis, or Github Actions.

aidun commented 4 years ago

@LucasRoesler I will take this issue

aidun commented 4 years ago

Should it be a flag, which defaults to true?

aidun commented 4 years ago

I have submited a pr for this. But I have a few questions, because I don't know much about github releases and travis:

  1. What do you mean with release? A PR which is merged into the master?
  2. Where is the release mechanism? So I can decide wether to push or not.
alexellis commented 4 years ago

We already push tags, look at the .travis.yml file to see where it all starts from. We just need to also push the latest tag along with the release version.

aidun commented 4 years ago

Okay, then I did it the right way in my PR. I was only concerned about the term release. But it seems that release means merged PR or direct commit. Thank you for the clarification!

Von: Alex Ellis notifications@github.com Gesendet: Monday, March 9, 2020 10:47:11 PM An: openfaas/faas-cli faas-cli@noreply.github.com Cc: Markus Hartmann markush1986@gmail.com; Comment comment@noreply.github.com Betreff: Re: [openfaas/faas-cli] Push latest image to Docker Hub (#772)

We already push tags, look at the .travis.yml file to see where it all starts from. We just need to also push the latest tag along with the release version.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/openfaas/faas-cli/issues/772?email_source=notifications&email_token=AACVCURZL7CWKKB77UKQCZDRGVPV7A5CNFSM4LDDMZD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOJGBDA#issuecomment-596795532, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACVCUV5E4TVJN6UYMOFH3TRGVPV7ANCNFSM4LDDMZDQ.