search

openfaas / faas-cli

Official CLI for OpenFaaS
https://www.openfaas.com/
Other
798 stars 224 forks source link

Question on deleting functions from multiple-namespaces #811

Closed zadigus closed 4 years ago

zadigus commented 4 years ago

I have the following faas-stack.yml:

version: 1.0
provider:
  name: openfaas
  gateway: ${OPENFAAS_GATEWAY_URL:-http://localhost:31112}
functions:
  login:
    namespace: ${OPENFAAS_NAMESPACE:-dev-fn}
    lang: dockerfile
    handler: ./backend/functions/Login
    image: shopozor/login-fn

I can up the stack like this:

faas-cli up -f faas-stack.yml

That works, though I've been struggling a lot trying to make it work. Indeed, I get the following confirmation:

Deployed. 202 Accepted.
URL: http://localhost:31112/function/login.dev-fn

Now, my issue is that the following command does not remove the functions declared in my stack:

faas-cli remove -f faas-stack.yml

Even though I get the confirmation

Deleting: login.

the function is actually not removed. Instead, I need to call

faas-cli remove login -g ${OPENFAAS_GATEWAY_URL} -n dev-fn

Then I get the confirmation

Deleting: login.
Removing old function.

and the function is really removed. From that behavior, I understand the namespace value in the faas-stack.yml is ignored in the remove command, which is surprising.

Expected Behaviour

The command

faas-cli remove -f faas-stack.yml

should provide the same result as the command

faas-cli remove login -g ${OPENFAAS_GATEWAY_URL} -n dev-fn

in that simple case where I only have one function. Of course, with more functions, the former command should successfully remove all the functions from the namespace specified in the yaml file.

Current Behaviour

The command

faas-cli remove -f faas-stack.yml

has no effect in the specified namespace.

Possible Solution

Currently, my work-around is to manually remove all the functions from the stack with commands like:

faas-cli remove login -g ${OPENFAAS_GATEWAY_URL} -n dev-fn

Of course, that's annoying, because I have a stack file with my whole defined there! I don't want to type one line of code for each function I have in my stack. I'd rather like to use the stack, which works for deployment.

Steps to Reproduce (for bugs)

  1. Create a simple stack 
    version: 1.0
provider:
name: openfaas
gateway: ${OPENFAAS_GATEWAY_URL:-http://localhost:31112}
functions:
login:
namespace: ${OPENFAAS_NAMESPACE:-dev-fn}
lang: dockerfile
handler: ./backend/functions/Login
image: shopozor/login-fn
  2. Up the stack 
    faas-cli up -f faas-stack.yml

    See that your functions are up.

  3. Remove the stack 
    faas-cli remove -f faas-stack.yml

    See that your functions are still up and never vanish from your function namespace.

Context

I'm pretty new to openfaas. I started using it this week. I am trying to deploy my .Net Core functions to my k8s cluster in the simplest possible way. I have already a pretty big stack of helm charts to deploy, together with functions that I am currently developping for my e-commerce platform.

Your Environment

Server: Docker Engine - Community Engine: Version: 19.03.8 API version: 1.40 (minimum version 1.12) Go version: go1.12.17 Git commit: afacb8b Built: Wed Mar 11 01:29:16 2020 OS/Arch: linux/amd64 Experimental: false containerd: Version: v1.2.13 GitCommit: 7ad184331fa3e55e52b890ea95e65ba581ae3429 runc: Version: 1.0.0-rc10 GitCommit: dc9208a3303feef5b3839f4323d9beb36df0a9dd docker-init: Version: 0.18.0 GitCommit: fec3683

* Are you using Docker Swarm (FaaS-swarm ) or Kubernetes (FaaS-netes)?
I am using kubernetes on Docker for Desktop under Windows:

Client Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.6-beta.0", GitCommit:"e7f962ba86f4ce7033828210ca3556393c377bcc", GitTreeState:"clean", BuildDate:"2020-01-15T08:26:26Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"windows/amd64"} Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.6-beta.0", GitCommit:"e7f962ba86f4ce7033828210ca3556393c377bcc", GitTreeState:"clean", BuildDate:"2020-01-15T08:18:29Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}



* Operating System and version (e.g. Linux, Windows, MacOS):
Windows

* Link to your project or a code example to reproduce issue:
You don't need anything special. Just create a new function from some template and you should be able to reproduce this.
alexellis commented 4 years ago

/set title: Question on deleting functions from multiple-namespaces

alexellis commented 4 years ago

@LucasRoesler please could you take this one?

LucasRoesler commented 4 years ago

Sure, I wont have much time to dedicate until tomorrow, but i will take a look.

LucasRoesler commented 4 years ago

I took a very brief look at the remove command and the bug is pretty clear to me, this line only references the namespace from the flag

https://github.com/openfaas/faas-cli/blob/080cde3a486e2cb7d72e411874f6e57b11073959/commands/remove.go#L83

I am starting to think that we should consider changing the implementation in the CLI so that the yaml parser can accept an overrides object and hopefully implement the overrides consistently.

https://github.com/openfaas/faas-cli/blob/080cde3a486e2cb7d72e411874f6e57b11073959/stack/stack.go#L68

// StackOverrides contains the optional values that can be overridden in the stack.yaml
// when the file is being parsed. 
//
// StackOverrides is generally constructed from the CLI flags.
type StackOverrides struct {
   // Namespace sets the namespace of all functions in the stack to the given value
   Namespace *string
   //... etc
}

// SetNamespace is a helper for configuring the namespace override
func (o *StackOverrides) SetNamespace(v string) { 
    o = &v
}

The quick fix is going to look similar to the patch we just did on the deploy command

alexellis commented 4 years ago

@LucasRoesler can this be closed after #812 was merged? I am asking because normally when Closes / Fixes: is added to a PR it will automatically close the linked Issue.

LucasRoesler commented 4 years ago

yes

zadigus commented 4 years ago

In what release will that fix be available? Thanks for your prompt fix, btw.

alexellis commented 4 years ago

It's already been released, you can get regular updates via the Insiders Updates or read the release notes on this repo under the releases tab to find out which.