openfaas / faas-cli

Official CLI for OpenFaaS
https://www.openfaas.com/
Other
794 stars 226 forks source link

Fixes for the --watch flag for faas-cli up #969

Closed alexellis closed 1 year ago

alexellis commented 1 year ago

Fixes for the --watch flag for faas-cli up due to incomplete / defective feature PR.

Description

Motivation and Context

Fixes: #968

How Has This Been Tested?

Tested with:

Types of changes

alexellis commented 1 year ago

cc @nitishkumar71 @nitishkumar71 @welteki

alexellis commented 1 year ago

I've added a note on why --watch won't work with localrun with the current design.

We need some kind of Go routine, cancellation/context approach so that the docker run which is blocking, doesn't block the watcher code - and the watcher code has a chance to kill the docker run for a prior version before starting a new build/run.