openfaas / faas-netes

Serverless Functions For Kubernetes
https://www.openfaas.com
MIT License
2.13k stars 472 forks source link

[Feature] multiple namespace support #511

Closed alexellis closed 3 years ago

alexellis commented 5 years ago

Feature: multiple namespace support

The feature is outlined at https://github.com/openfaas/faas-netes/issues/433, which can be used for comments, questions, and suggestions.

The use-case is: multiple namespaces, single installation, i.e. dev/staging, team-a/team-b, client-a/client-b.

Checklist:

CLI

Secrets

Logs

Docs

Triggers

OpenFaaS operator

Diagram

Test out the patches so far

Test e2e with this Gist and the following patches: https://gist.github.com/alexellis/3b285ca0952d4cef48ca5dbff7e4e288

viveksyngh commented 5 years ago

I will work on updating faas-netes to make secrets API namespace aware and add namespace flag to the secrets command to CLI.

jonatasbaldin commented 5 years ago

hey @viveksyngh, I'm working on the faas-netes, faas-provider and faas for that already 🙈

would u like to focus on the CLI?

for the GET /system/secrets I'm gonna pass a namespace query parameter and for the other ones (POST, PUT, DELETE) I'll pass a new namespace field in the body.

what do u think?

jonatasbaldin commented 5 years ago

I have a POC working locally already, will cleanup and push today :)

viveksyngh commented 5 years ago

or the GET /system/secrets I'm gonna pass a namespace query parameter and for the other ones (POST, PUT, DELETE) I'll pass a new namespace field in the body.

I think that should be fine. Please let me know if you need any help.

I can work on the CLI.

jonatasbaldin commented 5 years ago

Here's the PRs from the Secrets:

❤️