openfaas / faas-netes

Serverless Functions For Kubernetes
https://www.openfaas.com
MIT License
2.12k stars 473 forks source link

Reflect helm 3 syntax in documentation chart/openfaas/README.md #576

Closed mkoeper closed 3 years ago

mkoeper commented 4 years ago

Expected Behaviour

Instructions for deployment with "helm template" should reflect new syntax as of helm version 3

Current Behaviour

Instructions for deployment with "helm template" fail for helm version 3.0.2

Possible Solution

Created pull request.

Steps to Reproduce (for bugs)

c.f. pull request "Generating openfaas.yaml with helm 3"

Context

Your Environment

Gateway uri: http://127.0.0.1:31112 version: 0.18.7 sha: 59b7839236098820e73ed25301258b722c3d33e4 commit: Change how and when we fetch and parse namespace info

Provider name: faas-netes orchestration: kubernetes version: 0.9.15 sha: 41c33f9f7c29e8276bd01387f78d6f0cff847890


* Docker version `docker version` (e.g. Docker 17.0.05 ):

$ docker version Client: Docker Engine - Community Version: 19.03.5 API version: 1.40 Go version: go1.12.12 Git commit: 633a0ea Built: Wed Nov 13 07:22:37 2019 OS/Arch: windows/amd64 Experimental: false

Server: Docker Engine - Community Engine: Version: 19.03.5 API version: 1.40 (minimum version 1.12) Go version: go1.12.12 Git commit: 633a0ea Built: Wed Nov 13 07:29:19 2019 OS/Arch: linux/amd64 Experimental: false containerd: Version: v1.2.10 GitCommit: b34a5c8af56e510852c35414db4c1f4fa6172339 runc: Version: 1.0.0-rc8+dev GitCommit: 3e425f80a8c931f88e6d94a8c831b9d5aa481657 docker-init: Version: 0.18.0 GitCommit: fec3683 Kubernetes: Version: v1.17.0 StackAPI: Unknown


* What version and distriubtion of Kubernetes are you using? `kubectl version`

$ kubectl version Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.8", GitCommit:"211047e9a1922595eaa3a1127ed365e9299a6c23", GitTreeState:"clean", BuildDate:"2019-10-15T12:11:03Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"windows/amd64"} Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-20T01:47:38Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}



* Operating System and version (e.g. Linux, Windows, MacOS):
Windows 10 Pro, Version 1903, Build 18362.535
alexellis commented 3 years ago

/lock: inactive. Feel free to raise a new issue if this is still required by anyone.