Functions are manipulated in non-annotated namespace

martindekov commented 4 years ago

Functions should only be created/deleted etc. In namespaces which have annotation openfaas=1/true in faas-netes and operator. Currently the logic rejects secrets created in those namespaces, but creates functions.

Expected Behaviour

Try creating function in namespace which does not have annotation results in failure.

Current Behaviour

Creating function in namespace with no openfaas=1 annotation succeeds.

Possible Solution

Check query namespaces before creating function similar to logic in handlers.ListNamespaces

Steps to Reproduce (for bugs)

Deploy faas-netes/operator with ClusterRole to true to enable multiple namespaces support
Create namespace staging-fn without annotation
Create function check it succeeds
Create secret and check 4xx status

Context

Similar problem exists while developing multiple namespaces support for the operator.

Your Environment

FaaS-CLI version ( Full output from: faas-cli version ): N/A
Docker version docker version (e.g. Docker 17.0.05 ): N/A
What version and distriubtion of Kubernetes are you using? kubectl version N/A
Operating System and version (e.g. Linux, Windows, MacOS): N/A
Link to your project or a code example to reproduce issue: N/A
What network driver are you using and what CIDR? i.e. Weave net / Flannel N/A

alexellis commented 4 years ago

Is this fixed by #673 @martindekov ?

martindekov commented 4 years ago

No Alex, I will open separate PR with this change.

openfaas / faas-netes