Replace proxy handler with provider implementation

LucasRoesler commented 5 years ago

Description

Update the faas-provider version
Update the gorilla mux version to enable simpler unit tests
Refactor the function proxy handler to use the the new proxy implementation
Parse the dnsrr env variable during server startup instead of each function invocation
Unit test the function resolver to ensure that errors are propagated

Motivation and Context

[X] I have raised an issue to propose this change #38 (required)

How Has This Been Tested?

Additional unit tests have been provided to ensure that the resolver works as expected. The Proxy handler is unit tested upstream in the faas-provider

I have also manually tested this by deploying to my local docker swarm using the deploy_stack.sh in openfaas/faas project with two modifications

update the docker-compose.yaml line 17 so that it has direct_functions: "false"
update the docker-compose.yaml line 44 so that it has image: theaxer/faas-swarm:new-proxy

I then went to the UI on localhost, deployed a function from the Store and verified that the function invoke worked as expected. I then did the same form the CLI, building, deploying, and then invoking a function.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Note that this removes the x-function header functionality that allows the user to set the function name via a header value. This has been deprecated for some time and is not implemented in the faas-provider

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

alexellis commented 5 years ago

Hi Lucas, are there any functional changes in this PR?

Alex

LucasRoesler commented 5 years ago

This removes the deprecated xFuntionHeader functionality

xFunctionHeader := r.Header["X-Function"]
            if len(xFunctionHeader) > 0 {
                log.Print("X-Function: ", xFunctionHeader)
            }

Forgot about that change, I will update the notes

alexellis commented 5 years ago

Right the only valid values across the project are 0/1 and true/false in those cases.

LucasRoesler commented 5 years ago

@alexellis I have addressed each of your comments except for this one, which I left a comment on https://github.com/openfaas/faas-swarm/pull/39#discussion_r232453514 . Github incorrectly marked it as outdated due to another change near the same line.

LucasRoesler commented 5 years ago

@alexellis should be ready for a last look now

alexellis commented 5 years ago

Thanks so much @LucasRoesler, this was a big change across at least a couple of repos. I appreciate the attention to detail on this too.

openfaas / faas-swarm