openfaas / faas-swarm

OpenFaaS provider for Docker Swarm
https://github.com/openfaas/faas
MIT License
79 stars 38 forks source link

Added secret handler #42

Closed bartsmykla closed 5 years ago

bartsmykla commented 5 years ago

Signed-off-by: Bart Smykla bsmykla@vmware.com

Description

Added secret handler

Added:

Fixes: #41

How Has This Been Tested?

It was tested by calling the secret endpoints via CURL and looking if intended action was done.

Types of changes

Checklist:

ivanayov commented 5 years ago

I don't know if there's an agreement not to support secret rm. This would be useful/needed when a secret is wrongly created or needs update.

bartsmykla commented 5 years ago

@alexellis can you review it again? @LucasRoesler maybe you could also have a look?

alexellis commented 5 years ago

Hi @bartsmykla I see it says that you've tested this so I'm going to merge and release.

Let me know if there are any issues with this going to users?

Alex