Invoke function in the UI is not working when direct_function is set to false

phgache commented 4 years ago

My actions before raising this issue

[x] Followed the troubleshooting guide
[x] Read/searched the docs
[x] Searched past issues

Expected Behaviour

The "invoke" button should call the function and the UI shoud show the function return.

Current Behaviour

As you can the see the call is failing because when the operator try to lookup for the function service, the name used is concatenated with the namespace. This is working with direct_function set to true because in this case the operator is not involved.

Given that, imho there is two options :

Removing the namespace when the UI is calling the function because it is working in both mode (direct_function)
Make the gateway and operator being able to work with the namespace added to the function name.

I have seen new feature about using multiple namespaces so the option 2 is maybe the best one as it will probably have less impacts.

Possible Solution

I’m not 100% sure that this is the best option, but as OpenFaaS does not support multiple namespace when direct_function is set to false, removing it in the « trimURLTransformer » could be an option :

main.go

    nilURLTransformer := handlers.TransparentURLPathTransformer{}
    trimURLTransformer := handlers.FunctionPrefixTrimmingURLPathTransformer{}

    if config.DirectFunctions {
        functionURLResolver = handlers.FunctionAsHostBaseURLResolver{
            FunctionSuffix:    config.DirectFunctionsSuffix,
            FunctionNamespace: config.Namespace,
        }
        functionURLTransformer = trimURLTransformer
    } else {
        functionURLResolver = urlResolver
        functionURLTransformer = nilURLTransformer
    }

forwarding_proxy.go

// Transform returns the URL path unchanged.
func (f TransparentURLPathTransformer) Transform(r *http.Request) string {
    return r.URL.Path // remove the namespace at the end
}

Steps to Reproduce (for bugs)

Deploy the openfaas with direct_functions set to false
Deploy nodeinfo function sample
Hit the invoke button

Context

This issue seems to only occurs in the UI which is has a minimal impact on our project. I raise this issue also to be sure that there is no further impact that I was not able to see.

Your Environment

FaaS-CLI version ( Full output from: faas-cli version ): 0.12.4
Docker version docker version (e.g. Docker 17.0.05 ): 19.03.13-beta2
Are you using Docker Swarm or Kubernetes (FaaS-netes)? Kubernetes
Operating System and version (e.g. Linux, Windows, MacOS): MacOs 10.15.4
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs from troubleshooting guide

If using Swarm, run the following and include the output:

curl -sLS https://raw.githubusercontent.com/moby/moby/master/contrib/check-config.sh | bash

Next steps

You may join Slack for community support.

LucasRoesler commented 4 years ago

We are getting really close with multiple namespace support in the operator, i would rather fix this bug in the operator instead of hacking the gateway here. I will definitely take a look this weekend

LucasRoesler commented 4 years ago

@phgache I have created a potential fix in faas-netes, if you checkout https://github.com/openfaas/faas-netes/pull/683 you can see the testing instructions and if you are feeling adventurous, give it a try and help us verify the fix

alexellis commented 4 years ago

Fixed in: https://github.com/openfaas/faas-netes/releases/tag/0.12.3

@phgache please could you try it out?

phgache commented 4 years ago

Hi,

I have deployed the new version and the bug is fixed.

Thanks @LucasRoesler & @alexellis

openfaas / faas