Closed alexellis closed 3 years ago
I can work on this!
Thank you
@dmcclory it's almost one month on since you volunteered to take this task. Have you made any progress or should we allow someone else in the community or @openfaas/faas-team to pick this up?
Hi @alexellis - I've been doing some work on it, it's taken me a little longer than I anticipated to get figure out angular. But I think I've turned a corner and I'm pretty close to having something. Right now I have it as a floating action button in the lower right part of the screen:
How does that look? Is there a better spot to place it?
Thanks for the update. I was wondering whether it might sit as three dots up by the logo or by the deploy from store button. If you're on Slack you could post this link above into #ui-taskforce to get some other suggestions/help if needed.
Alex
Derek add label: Hacktoberfest
Hi @alexellis It looks like it's been a while since there has been an update on this. Is it okay if I take it up? I'm new here and this doesn't look too complicated.
Please do :+1:
Can you send 2-3 mockups into this issue too?
Yup. Working on it.
@alexellis what kind of information are we expecting to display? The endpoint currently just seems to be providing the last Commit message and SHA along with the orchestration type.
Let's show what we have and hide the commit message.
I think it'd make more sense offset to the right than the left.
Do you have a screenshot of the pop-up?
Alex
@alexellis, sorry had a busy week. I actually moved it to the right but on smaller screens the left arrow pops up in the side bar and the text 'OpenFaas Portal' wraps to a new line due to space constraints. I put the button below now, does this look okay? -
And the popup:
I'd rather see the ":" on the right of the text, not the left because European readers read left to right.
I'd also like the pop-up to look like the Function Store pop-up.
Perhaps we can also offset the key / value fields as a form so that it has a better layout / padding.
Would you be able to make both those changes please?
This is the issue I mentioned earlier:
I guess I can 'squash' the 3-dots button to occupy lesser space.
Hey @jagreehal, wdyt?
Something like this?
First thoughts are why not just use info-circle as the icon?
Personally I don't like modals to display information like this.
Could this information be displayed at the bottom of the left column?
In addition I'd consider making the list of functions scroll separately to the page.
@jagreehal the functions list is not scrollable, so where exactly do I put this information?
Thanks for your input @jagreehal the Info icon also makes sense for me or some other glyphicon.
The page needs an overhaul when we move to React. Since the re-write is taking some time to get off the ground. Is there a way this can make sense as an info icon/modal or something similar?
@alexellis I guess the requirements/design has to be decided before I get to working on it.
@jagreehal, @alexellis does this look better?
The text at the bottom is sticky.
@alexellis can I get your decision on this?
How does it look when you have functions with scroll i.e. deploy 20 functions?
@phanix5 agree, generally prefer to see 2-3 mock-ups before actually doing work on it.
Alex
@alexellis The text stays on top of the functions list -
@alexellis can I get your call on this? Is this still relevant given the new UI with React?
/lock: inactivity
Expected Behaviour
Using a Glyphicon we can now surface the information provided by
/system/info
which gives relevant versions and the back-end type. Seefaas-cli version
as an example of the data or call the endpoint on your own gateway.Current Behaviour
Version available via API or
faas-cli version
Context
This data is now fully available in the API and stable. The original intention was for it to be surfaced in some way. A model dialog may be suitable.
Your Environment
This would work across all versions transparently cc @ewilde