openfaas / faasd

A lightweight & portable faas engine
https://store.openfaas.com/l/serverless-for-everyone-else
Other
3k stars 214 forks source link

Using $SUDO instead of sudo in install.sh #285

Closed yoshino-s closed 2 years ago

yoshino-s commented 2 years ago

Due diligence

Why do you need this?

We use $SUDO in other place, but why we use sudo only in here?

Expected Behaviour

install_arkade(){
  curl -sLS https://get.arkade.dev | $SUDO sh
  arkade --help
}

Current Behaviour

install_arkade(){
  curl -sLS https://get.arkade.dev | sudo sh
  arkade --help
}

Are you a GitHub Sponsor (Yes/No?)

Check at: https://github.com/sponsors/openfaas

List All Possible Solutions and Workarounds

Just replace it will be fine.

alexellis commented 2 years ago

Thanks for letting us know.