search

openfaas / faasd

A lightweight & portable faas engine
https://store.openfaas.com/l/serverless-for-everyone-else
MIT License
2.97k stars 213 forks source link

Enable quicker shutdown #332

Closed alexellis closed 10 months ago

alexellis commented 1 year ago

Description

Enable quicker shutdown

When write_timeout: 30s is set to a long value, the function can hang when being removed with certain templates i.e. golang-middleware

Motivation and Context

Reduces default grace period from 30s to 5s for removing functions.

The healthcheck_interval env-var can be used to override the value and set it higher or lower.

At times, removing a function will hang or fail, and is confusing to users.

How Has This Been Tested?

No testing yet, beyond building the code

Types of changes

alexellis commented 12 months ago

At times, removing a function will hang or fail, and is confusing to users.

@nitishkumar71 @LucasRoesler did you get any further with this?

This fell off my radar and I think it needs some more investigation / exploration of edge cases.

LucasRoesler commented 11 months ago

@alexellis i am a bit confused, are you just asking for some testing?

alexellis commented 11 months ago

That's right @LucasRoesler - you told me that you'd done some testing on this, but I'm having issues with it, with a longer timeout on my golang-middleware function.