openfaas / faasd

A lightweight & portable faas engine
https://store.openfaas.com/l/serverless-for-everyone-else
MIT License
2.97k stars 213 forks source link

faasd namespace support openfaas=true instead of openfaas=1 #351

Closed nitishkumar71 closed 9 months ago

nitishkumar71 commented 9 months ago

Due diligence

faasd does not deploys functions into the namespace with label openfaas=1

My actions before raising this issue

Before you ask for help or support, make sure that you've consulted the manual for faasd. We can't answer questions that are already covered by the manual. NA

Why do you need this?

It's a bug

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file? NA

Expected Behaviour

faasd should deploys functions into the namespace with label openfaas=1

Current Behaviour

faasd deploys functions into the namespace with label openfaas=true

List All Possible Solutions and Workarounds

Which Solution Do You Recommend?

Steps to Reproduce (for bugs)

  1. faas-cli ns create ns-test uses go-sdk internally which add label openfaas=1
  2. Run sudo ctr ns ls which produces below output
    NAME        LABELS                                                             
    ns-test     openfaas=1                                                       
    openfaas                                                                       
    openfaas-fn 
  3. Run faas-cli store deploy env -n ns-test which produces below output Unexpected status: 400, message: namespace not valid