Fix sometimes the faas container cannot be started

shivabohemian commented 5 months ago

When obtaining the container information fails, the key for deleting the snapshot is incorrect

Description

Motivation and Context

[ ] I have raised an issue to propose this change this is required

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

[x] I've read the CONTRIBUTION guide
[x] My commit message has a body and describe how this was tested and why it is required.
[x] I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

[x] My code follows the code style of this project.
[ ] I have added tests to cover my changes.

Docs:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

alexellis commented 5 months ago

What happened to thsi PR? Why was it closed?

https://github.com/openfaas/faasd/pull/358 seems to do less?

shivabohemian commented 5 months ago

Because it has a cyclic dependency.

alexellis commented 5 months ago

It would be helpful for the maintainers if you wrote a comment to explain why you're opening/closing PRs etc. Thanks

shivabohemian commented 5 months ago

I noticed there is a unified constants.go to maintain constants, which can prevent such suffix errors through this way of defining constants. Regrettably, there was a cyclic dependency that I didn't notice, so I have withdrawn the PR.

openfaas / faasd