openfaas / faasd

A lightweight & portable faas engine
https://store.openfaas.com/l/serverless-for-everyone-else
MIT License
2.97k stars 213 forks source link

Fix snapshot key error #358

Closed shivabohemian closed 5 months ago

shivabohemian commented 5 months ago

When obtaining the container information fails, the key for deleting the snapshot is incorrect.

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Commits:

Code:

Docs:

alexellis commented 5 months ago

The solution looks correct so I'll merge it, but we need issues to be created before PRs, and proof of the issue, plus proof of the fix.

alexellis commented 5 months ago

Feel free to test again, and see if your snapshots are being cleared up:

https://github.com/openfaas/faasd/releases/tag/0.18.7

shivabohemian commented 5 months ago

After I made changes to the code and tested it, things are indeed running normally now. Previously, an error like the one below would occur and it would require manual deletion of the snapshot in order to start successfully. Unexpected status: 400, message: unable to create container: nats, error: snapshot "nats-snapshot": already exists.

alexellis commented 5 months ago

That's great, thanks for picking this up.

What kinds of things are you using faasd for?

Would you like to meet us at the weekly call and chat more? https://docs.openfaas.com/community/#weekly-office-hours