search

openfaas / golang-http-template

Golang templates for OpenFaaS using HTTP extensions
https://www.openfaas.com/
MIT License
106 stars 57 forks source link

Added static file support in golang-middleware #17

Closed zbblanton closed 5 years ago

zbblanton commented 5 years ago

Description

Added the command to copy static files along with chown to own the app folder. Fixes #7.

How Has This Been Tested?

Tested by creating a function using the golang-middleware template and adding files other than handler.go. Then built the function and used docker run to start the container and manually verified the files were copied.

Not tested on ARM. No hardware to test with.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

zbblanton commented 5 years ago

PR for #7

rgee0 commented 5 years ago

Thanks Zachary. Can you edit the description to include Fixes #7 please? This just helps us keep issues in check.

alexellis commented 5 years ago

Not tested on ARM. No hardware to test with.

How have you tested it then?

Alex

zbblanton commented 5 years ago

Updated the description @rgee0.

Added how I tested manually @alexellis.

alexellis commented 5 years ago

Please make the changes for the armhf templates also. Send a GitHub repo which shows this working so that we can have someone else verify from the Slack community in #arm-and-pi before merging.

Alex

alexellis commented 5 years ago

@zbblanton please can you finish your PR? It's been around 8 weeks since we spoke last.

alexellis commented 5 years ago

I'll finish this personally. Not sure what happened here 👎