search

openfaas / golang-http-template

Golang templates for OpenFaaS using HTTP extensions
https://www.openfaas.com/
MIT License
106 stars 57 forks source link

Timeout should match value in environment #20

Closed brandonkal closed 5 years ago

brandonkal commented 5 years ago

Description

This change fixes the issue of the hard-coded timeout value. This fixes #9 I ran into this issue here: https://github.com/openfaas-incubator/of-watchdog/issues/50

This is not yet complete (must be duplicated 4x). This is what I needed to change to get my long running function to work and I am looking for feedback here.

How Has This Been Tested?

I have tested this in my environment. See https://github.com/openfaas-incubator/of-watchdog/issues/50#issuecomment-465430595

How are existing users impacted? What migration steps/scripts do we need?

Values set for "write_timeout" will be respected.

Checklist:

I have:

derek[bot] commented 5 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --sign-off and then git push --force.

rajatjindal commented 5 years ago

Hi @brandonkal

Do you intend to finish this PR. If not, I would like to submit this and get merged.

Thanks Rajat Jindal

alexellis commented 5 years ago

@rajatjindal given that this was last touched in Feb, I'm going to close. Please raise a new PR and do the fix there.

alexellis commented 5 years ago

@brandonkal thanks for having started this :+1: