golang-middleware: Body not closed

[alexellis]

In the default handler for golang-middleware the body is not closed of the request. This is generally done when reading the body.

I'd expect to see something like:

defer r.Body.Close()

[alexellis]

cc @stefanprodan

[alexellis]

https://github.com/openfaas-incubator/golang-http-template/blob/master/template/golang-middleware-armhf/main.go#L16

https://github.com/openfaas-incubator/golang-http-template/blob/master/template/golang-middleware/main.go#L16

[0sc]

Can I work on this?

[alexellis]

Sure, are you confident you can do the testing too?

Alex

[0sc]

I can try. What should the testing look like?

[alexellis]

Building a function with the template, deploying it and invoking it.

[0sc]

I was thinking since the issue is about fixing the not closed request body, testing with default http requests might suffice.

[alexellis]

Derek close: fixed by @rdimitrov

[alexellis]

@0sc there's a couple of more small issues on this repo if you're interested.