openfaas / golang-http-template

Golang templates for OpenFaaS using HTTP extensions
https://www.openfaas.com/
MIT License
106 stars 57 forks source link

chore: remove unused atomic int #85

Open mrwormhole opened 1 year ago

mrwormhole commented 1 year ago

My actions before raising this issue

Why do you need this?

I don't need this, I just realized this value is never been used, I am trying to make sense of it for the last 2 weeks, hopefully, this is not an awkward issue to bother people's time. I remember this variable being used in the past when I started learning faasd (around Go version 1.15 1.16 templates)

Expected Behaviour

The variable is set and it should be used

Current Behaviour

The variable is set but never used

https://github.com/openfaas/golang-http-template/blob/master/template/golang-http/main.go#L74 https://github.com/openfaas/golang-http-template/blob/master/template/golang-middleware/main.go#L72

List All Possible Solutions and Workarounds

the solution is just removing the unused variable

Steps to Reproduce (for bugs)

it is not a bug really.

Your Environment

Next steps

You may join Slack for community support.