Move from Travis CI to Github Actions

akosveres commented 3 years ago

Description

The pull request has the following changes:

Remove .travis.yaml
Add build and publish github actions workflow
Update README.md with new badge and documentation

Motivation and Context

[ ] I have raised an issue to propose this change (required) Fixes issue https://github.com/openfaas/faas/issues/1585

How Has This Been Tested?

I've done tests on my fork: Successful build workflow https://github.com/akosveres/nats-queue-worker/runs/1365348972?check_suite_focus=true Succesful publish workflow https://github.com/akosveres/nats-queue-worker/runs/1365361432?check_suite_focus=true

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 3 years ago

Have you tested a release build on your own account? Most that I merged yesterday failed leaving broken tags

akosveres commented 3 years ago

Have you tested a release build on your own account? Most that I merged yesterday failed leaving broken tags

I have as much as I could, in this repository we only take the git tag, not the sha and that looks correct.

alexellis commented 3 years ago

@akosveres do you have a moment to revisit the comments today?

alexellis commented 3 years ago

This PR is required to complete our migration, so I'm closing due to inactivity.

@utsavanand2 please can you take over in a new PR and make this work like the faas-netes or faas build please?

Pay attention to how we set the version and commit information in the image and the GitHub Action.

openfaas / nats-queue-worker