search

openfaas / nats-queue-worker

Queue-worker for OpenFaaS with NATS Streaming
https://docs.openfaas.com/reference/async/
MIT License
129 stars 59 forks source link

ci: Add GitHub Actions worflows and remove travis #106

Closed cpanato closed 3 years ago

cpanato commented 3 years ago

Description

ci: Add GitHub Actions worflows and remove travis

Motivation and Context

How Has This Been Tested?

n/a

Types of changes

Checklist:

derek[bot] commented 3 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

cpanato commented 3 years ago

build ran on my account: https://github.com/cpanato/nats-queue-worker/runs/2289345158?check_suite_focus=true

cpanato commented 3 years ago

/assign @alexellis

alexellis commented 3 years ago

Hi @cpanato, thank you for this PR.

Could you run through a basic test on your repo please? Both for a build, and a release. The release will push a Docker image if it's working right.

Given the way the GH actions work, it templates your username and uploads an image to your own custom GHCR.io repo for testing.

Alex

cpanato commented 3 years ago

@alexellis the two workflows ran on my account

build: https://github.com/cpanato/nats-queue-worker/runs/2311878376?check_suite_focus=true publish: https://github.com/cpanato/nats-queue-worker/runs/2311894847?check_suite_focus=true

image available at ghcr.io/cpanato/nats-queue-worker:v99.99.99

PTAL when you have some free time

alexellis commented 3 years ago

We can also move to secrets.GITHUB_TOKEN now instead of individual secrets that I create and manage.