openfaas / nats-queue-worker

Queue-worker for OpenFaaS with NATS Streaming
https://docs.openfaas.com/reference/async/
MIT License
129 stars 59 forks source link

Auth needed for gateway calls to /system/async-report #35

Closed alexellis closed 6 years ago

alexellis commented 6 years ago

Expected Behaviour

The call to /system/async-report needs to be decorated with basic auth credentials.

Current Behaviour

It is open which is why no changes were needed, but this is invalid because someone could discover the gateway and post false statistics to this endpoint.

Possible Solution

Steps to Reproduce (for bugs)

  1. Deploy OpenFaaS with auth
  2. Post to gateway:port/system/async-report

Context

Found whilst doing a deeper code review on the faas/server entrypoint

viveksyngh commented 6 years ago

Derek assign: me