Remove HTTP Host header override - Githubissues

openfaas / nats-queue-worker

Queue-worker for OpenFaaS with NATS Streaming

https://docs.openfaas.com/reference/async/

MIT License

128 stars 59 forks source link

Remove HTTP Host header override #37

Closed stefanprodan closed 6 years ago

stefanprodan commented 6 years ago

Description

Fix for Istio integration https://github.com/openfaas/faas/issues/851

The gateway will create or forward the X-Forwarded-Host header that contains the original host, no need to override the http client Host. https://github.com/openfaas/faas/pull/861

Motivation and Context

[x] I have raised an issue to propose this change (required)

How Has This Been Tested?

Tested ok GKE with the Helm chart from https://github.com/openfaas/faas-netes/pull/279

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I've read the CONTRIBUTION guide
[ ] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

alexellis commented 6 years ago

Merged, thanks.