unified processing parse env max_inflight, ack_wait variable

feifeiiiiiiiiiii commented 6 years ago

Signed-off-by: qinpengfei qinpengfei@jd.com

Description

Describe #38

Motivation and Context

[x] I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

alexellis commented 6 years ago

Thanks for this PR 👍 I have left a comment for you.

alexellis commented 6 years ago

@LucasRoesler please could I ask you to give this a review? What I'd like is to be sure there is no unintended typo or regression made by the refactoring.

alexellis commented 6 years ago

Much appreciated.

alexellis commented 5 years ago

Great, thanks for putting your name to this Lucas. I'll merge since you've given it the rubber stamp.

openfaas / nats-queue-worker