Remove invalid hostname characters from nats client id

ewilde commented 5 years ago

Todo

Similar to #24 running this docker image on an ecs instance. ECS hostname contains . which is not supported by nats as a value for the clientid.

When running this docker image on Amazon ECS you get the following error:

stan: invalid clientID: only alphanumeric and-or_characters allowed.

This is because the ECS host name contains periods . i.e. ip-10-0-1-140.eu-west-1.compute.internal

[x] This has been tested on ECS in a custom build of nats-queue-worker and now starts properly

Test output:

Wait for 5m0s
Listening on [faas-request], clientID=[faas-worker-ip-10-0-4-89_eu-west-1_compute_internal], qgroup=[faas] durable=[]

Test output:

Loading basic authentication credentials
Wait for  5m0s
Listening on [faas-request], clientID=[faas-worker-2b97ea65f696], qgroup=[faas] durable=[]

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[? ] I have added tests to cover my changes. Didn't see any tests in the project, happy to add if that's what's wanted
[x] All new and existing tests passed.

alexellis commented 5 years ago

There's outstanding feedback, so we want to fix it before merging? @rgee0 @ewilde

LucasRoesler commented 5 years ago

@rgee0 and @alexellis is there anything else to do here?

ewilde commented 5 years ago

I just need to re-test since I addressed comments

alexellis commented 5 years ago

@ewilde please can you give an update?

I'm not sure if I can merge this since "todo" says "re-test" and the title says "WIP".

Alex

alexellis commented 5 years ago

Derek add label: blocked

ewilde commented 5 years ago

@alexellis PTAL, retested on swarm and fargate