openfaas / nats-queue-worker

Queue-worker for OpenFaaS with NATS Streaming
https://docs.openfaas.com/reference/async/
MIT License
129 stars 59 forks source link

Support durable queue subscriptions. #76

Closed bmcustodio closed 4 years ago

bmcustodio commented 4 years ago

Description

This PR adds support for durable queue subscriptions while maintaing the implementation backwards-compatibility.

Motivation and Context

75.

How Has This Been Tested?

Using the steps described in #75 while using the bmcstdio/openfaas-nats-queue-worker:nats-durable-queue-subscription image.

Types of changes

Checklist:

bmcustodio commented 4 years ago

@alexellis can we get this merged please? 🙏

alexellis commented 4 years ago

Thanks for the PR.

Something to note from the NATS team - durable subscriptions are not "cleaned up" when you disconnect, so you'd have to do that manually if they are named.