Support customising the NATS Streaming channel and queue group.

bmcustodio commented 4 years ago

Description

This PR adds support for customising the NATS Streaming channel and queue group used for asynchronous invocations, as per https://github.com/openfaas/faas/issues/1399, in a backwards-compatible way.

Motivation and Context

[x] I have raised an issue to propose this change (required)

https://github.com/openfaas/faas/issues/1399

How Has This Been Tested?

By running the included unit tests, which is enough in this case IMHO. There's also bmcstdio/openfaas-nats-queue-worker:pr-79, just in case.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

alexellis commented 4 years ago

Please could you rebase? After your other PR was merged this needs an update.

bmcustodio commented 4 years ago

@alexellis rebased!

alexellis commented 4 years ago

Thanks

alexellis commented 4 years ago

FYI https://github.com/openfaas/nats-queue-worker/releases/tag/0.9.0

openfaas / nats-queue-worker