openfaas / nats-queue-worker

Queue-worker for OpenFaaS with NATS Streaming
https://docs.openfaas.com/reference/async/
MIT License
128 stars 59 forks source link

Upgrade nats-streaming client #87

Closed matthiashanel closed 4 years ago

matthiashanel commented 4 years ago

Expected Behaviour

Use a current version of the nats streaming client.

Current Behaviour

A while ago the repository for the nats streaming client got moved from: https://github.com/nats-io/go-nats-streaming to : https://github.com/nats-io/stan.go Therefore, nats-queue-worker will not pick up bug fixes and improvements.

Possible Solution

Rename the package in go files, Gopkg.toml and update the vendor directory accordingly.

Context

February 22nd we we had contact about some behavior of the openfaas nats connector. One suggestion was to bump the version of the nats streaming server. I Recently realized that, due to the repository move, nats-queue-worker is locked in to an old version.

I'd be more than happy to contribute this change.