Closed mrwormhole closed 1 year ago
not agreed as a scope, will be parked
Will you suggest any fixes for these warnings? We can review it for you.
/set title: Implement suggestions from linter
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.
Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.
This will only take a few moments.
First, clone your fork and checkout this branch using the git CLI.
Next, set up your real name and email address:
git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"
Finally, run one of these commands to add the "Signed-off-by" line to your commits.
If you only have one commit so far then run: git commit --amend --signoff
and then git push --force
.
If you have multiple commits, watch this video.
Check that the message has been added properly by running "git log".
closing this as I am working on a less style based linter configuration that only focuses basic style and more of real bugs/issues with eliminated false positives, will probably do a gist and a blog on this as I have been dealing with linter configs for long time
Signed-off-by: F. Talha Altinel talhaaltinel@hotmail.com
Description
I have run golangci-lint v1.49.0 and used this config to eliminate false positives
Motivation and Context
How Has This Been Tested?
no this is not tested yet
Types of changes
Checklist:
git commit -s
Additional Note
I have found these errors as well but due to my limited knowledge, I didn't take action on these to not break the repository. Would be cool to discuss it after this PR change