Implement proposal 716, passing full paths through of-watchdog

[telackey]

An implementation of proposal #716, passing the full URL through the of-watchdog.

Description

Previous to these changes, only the query string provide by the HTTP client was passed through to the handling code. With these changes, the full URL path is passed as well as the query string.

Motivation and Context

• [X] I have raised an issue to propose this change

Proposal #716

How Has This Been Tested?

Manually.

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [X] Breaking change (fix or feature that would cause existing functionality to change)

Some of the templates have baked in routes of '/' (cf. the node8 template). Those will also need updated. The easiest will be to replace the explicit '/' route with a catchall:

-app.post('/', middleware);
-app.get('/', middleware);
+app.post('/*', middleware);
+app.get('/*', middleware);

Checklist:

• [X] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [X] I've read the CONTRIBUTION guide
• [X] I have signed-off my commits with git commit -s
• [X] I have added tests to cover my changes.
• [X] All new and existing tests passed.

This may or may not require a documentation change. The existing documentation, AFAIK, does not address the use of paths one way or the other.

Refs

Trello: https://trello.com/c/1qZMlGXU

[alexellis]

@telackey I'd like to see unit tests for this, but will merge and if there are any problems get in touch for a correction.

Alex

[telackey]

@alexellis Sounds good.

[alexellis]

This has been released along with the gateway and the node template. You should be able to move off your patches now. Looking forward to catching up soon.