openfaas / of-watchdog

Reverse proxy for STDIO and HTTP microservices
MIT License
259 stars 115 forks source link

Add Concurrency Limiter #53

Closed sargun closed 5 years ago

sargun commented 5 years ago

Description

This enables limiting concurrency. It is a naive approach which will reject requests as soon as they exceed the maximum number of in-flight requests.

Motivation and Context

How Has This Been Tested?

There are tests in the code that test for all of the obvious possible variants. The code is written in such a way that testing is easy.

Types of changes

Checklist:

alexellis commented 5 years ago

Derek close

alexellis commented 5 years ago

Derek add label: invalid

alexellis commented 5 years ago

Hi @sargun thank you so much for your interest in OpenFaaS.

I'm going to have to close your PR because you've not followed the contribution process, which is very clear.

Regards,

Alex

From the contributing guide:

https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md#i-have-a-great-idea

Please do not raise a proposal after doing the work - this is counter to the spirit of the project. It is hard to be objective about something which has already been done

alexellis commented 5 years ago

Derek reopen