Move source of concurrency limiter code to faas-middleware - Githubissues

openfaas / of-watchdog

Reverse proxy for STDIO and HTTP microservices

MIT License

259 stars 115 forks source link

Move source of concurrency limiter code to faas-middleware #58

Closed sargun closed 5 years ago

sargun commented 5 years ago

Description

The moves the concurrency limiter code from this project to faas-middleware.

Motivation and Context

The code is shared between the classic watchdog, and this watchdog, so it doesn't make sense to copy & paste.

How Has This Been Tested?

Tested with a forking backend:

#!/bin/bash
sleep 1
echo here

fprocess=./test.sh max_inflight=1 ./of-watchdog

and doing: for i in $(seq 5); do curl -v -s http://localhost:8080/ & done

And seeing the concurrency limiter kick in.

Checklist:

[X] My code follows the code style of this project.
[] My change requires a change to the documentation.
[] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

alexellis commented 5 years ago

Thank you for this PR. :+1: