Parse interger timeout #64

u5surf commented 5 years ago

Description

Motivation and Context

[o] I have raised an issue to propose this change ([required] (https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))

fixes #64

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

derek[bot] commented 5 years ago

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

alexellis commented 5 years ago

Hi,

Thanks for your interest in contributing.

Please could you do a few things before we consider merging the PR?

test your work and show evidence of that
add a unit test (if applicable)
fill out the whole template
see the implementation in the linked code and make sure you copy it, or mimick it

Thank you,

Alex

alexellis commented 5 years ago

We'll also need you to fill out the checklist.

alexellis commented 5 years ago

Hi :wave:

Thanks for updating the PR.

Please can you squash / reset your two commits into one? There is a typo "Parse interger timeout " that we wouldn't want in the history.

alexellis commented 4 years ago

Fixed in #79

openfaas / of-watchdog