The timeout values could be accidentally set as ints by a user
rather than golang durations. This meant that "5" gets parsed
to 0s not 5s. Now we try and parse non duration strings as
seconds.
This has been tested by creating a function with the old binary,
setting the timeouts for read, write and exec to "5" and 5.
These are interpreted as 0s.
New binary swapped in and re-deployed, this then worked as our
waits were less than the 5 seconds, when expanded over 5s (the waits)
then the fn was stopped
[x] I have raised an issue to propose this change (required)
64
How Has This Been Tested?
This has been tested by creating a function with the old binary,
setting the timeouts for read, write and exec to "5" and 5.
These are interpreted as 0s.
New binary swapped in and re-deployed, this then worked as our
waits were less than the 5 seconds, when expanded over 5s (the waits)
then the fn was stopped
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
Description
The timeout values could be accidentally set as ints by a user rather than golang durations. This meant that "5" gets parsed to 0s not 5s. Now we try and parse non duration strings as seconds.
This has been tested by creating a function with the old binary, setting the timeouts for read, write and exec to "5" and 5. These are interpreted as 0s.
New binary swapped in and re-deployed, this then worked as our waits were less than the 5 seconds, when expanded over 5s (the waits) then the fn was stopped
Signed-off-by: Alistair Hey alistair@heyal.co.uk
Fixes #64
Motivation and Context
64
How Has This Been Tested?
This has been tested by creating a function with the old binary, setting the timeouts for read, write and exec to "5" and 5. These are interpreted as 0s.
New binary swapped in and re-deployed, this then worked as our waits were less than the 5 seconds, when expanded over 5s (the waits) then the fn was stopped
Types of changes
Checklist:
git commit -s