search

openfaas / ofc-bootstrap

Bootstrap OpenFaaS Cloud for your team
https://docs.openfaas.com/openfaas-cloud/intro/
MIT License
179 stars 61 forks source link

Way to overrides values in template/gateway_config.yml #154

Open csakshaug opened 5 years ago

csakshaug commented 5 years ago

Today the templates/gateway_config.yml includes many essential values. Some of them are exposed to overrides in init.yaml But several are not. I think the best approach is to have default possible to override all "changeable" values. For gateway config template we are almost there, the are three values sticking out. L30-L32

Expected Behaviour

Possible to overrides the static values directly from init.yaml

Current Behaviour

All values are static

readonly_root_filesystem: true
scaling_min_limit: 1
scaling_max_limit: 4

Possible Solution

Add more values https://github.com/openfaas-incubator/ofc-bootstrap/blob/6accd2fbec50ea03f6775f0614e676fdaa0156dc/pkg/stack/stack.go#L39´ and set those values from ìnit.yaml

readonly_root_filesystem: {{.ReadonlyRootFileSystem}}
scaling_min_limit: {{.Scaling.MinLimit}}
scaling_max_limit: {{.Scaling.MaxLimit}}
alexellis commented 5 years ago

Approved 👍

Waterdrips commented 4 years ago

/assign: me

Ill get this done today if possible